search

octet-stream / form-data

Spec-compliant FormData implementation for Node.js
https://www.npmjs.com/package/formdata-node
MIT License
142 stars 17 forks source link

Create a one time deprecation warning #41

Closed jimmywarting closed 3 years ago

jimmywarting commented 3 years ago

...if they append Buffer or Streams and that it will be gone in v4 https://github.com/octet-stream/form-data/blob/fd7f6b18a8c6abb9c1dc7341ebb5846a0551bff0/lib/FormData.ts#L162-L167

octet-stream commented 3 years ago

formdata-node already has these deprecation warnings on both .append() and .set() methods. See: https://github.com/octet-stream/form-data/blob/fd7f6b18a8c6abb9c1dc7341ebb5846a0551bff0/lib/FormData.ts#L276-L277

image

octet-stream commented 3 years ago

By the way I am thinking to create an issue in formdata-node repo with v4 roadmap to bring what would change in v4 to developers attention as you did in node-fetch...

jimmywarting commented 3 years ago

Ah, missed that