search

octet-stream / form-data

Spec-compliant FormData implementation for Node.js
https://www.npmjs.com/package/formdata-node
MIT License
142 stars 17 forks source link

fix throw new Error(`.git can't be found (see ${url})`) #52

Closed gregory closed 2 years ago

gregory commented 2 years ago

More info here: https://github.com/typicode/husky/issues/851#issuecomment-777179899

fixes #51

octet-stream commented 2 years ago

Hi. Some people suggest to just move husky install to prepare script or just mention in readme to manually install husky in case if git hooks are necessary. Maybe one of these approaches will be better. Not sure which one. I will take a look at this later tonight. By renaming to _postinstall you will simply disable husky installation, I think for those who want to clone this repo and contribute too.

codecov[bot] commented 2 years ago

Codecov Report

Merging #52 (b4a992d) into master (ce0a808) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #52   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          996       996           
  Branches       137       137           
=========================================
  Hits           996       996
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ce0a808...b4a992d. Read the comment docs.

octet-stream commented 2 years ago

Im closing this, because postinstall script was removed. I also added the Git hooks section to readme.md I believe this resolved now.