search

octgn / OCTGN

Online Card and Tabletop Gaming Network
http://www.octgn.net
Other
359 stars 129 forks source link

game settings break with python dictionaries #1007

Open brine opened 11 years ago

brine commented 11 years ago

There's a bug in the way the setSetting API processes python dictionaries. When you attempt to store one, it'll get added incompletely to the settings.xml file, then the entire file will break. No other setSetting call will change the stored settings, even in other games. This is a huge concern for game devs as an improper setSetting from another game could mess up your own stuff.

kellyelton commented 10 years ago

Is this still a problem?

BenMatteson commented 10 years ago

closed due to new settings system

brine commented 10 years ago

it still technically exists, the new settings system is even more unforgiving to dictionaries

BenMatteson commented 10 years ago

oh... my bad then.

On Fri, Jan 10, 2014 at 12:56 PM, Kelly Elton notifications@github.comwrote:

Reopened #1007 https://github.com/kellyelton/OCTGN/issues/1007.

— Reply to this email directly or view it on GitHubhttps://github.com/kellyelton/OCTGN/issues/1007 .