octgn / OCTGN

Online Card and Tabletop Gaming Network
http://www.octgn.net
Other
359 stars 129 forks source link

Can't play cards in latest version of OCTGN ANR #1019

Closed yongqli closed 11 years ago

yongqli commented 11 years ago

+++ Processing. Please Hold... ----Python Error---- Traceback (most recent call last): TypeError: Value cannot be null. intPlay(Card(65598))

----End Error----

Broke in the latest version after updating ~20 min ago.

kellyelton commented 11 years ago

Looks like a python error. I would recommend disabling any automations and see if that helps.

db0 commented 11 years ago

it's not the automations. The latest update seems to have b0rked something about setting global vars. The following line is breaking but only intermitently

hostCards = eval(getGlobalVariable('Host Cards'))

kellyelton commented 11 years ago

That sounds like it would be fixed by disabling automations

db0 commented 11 years ago

That's not a fix.

kellyelton commented 11 years ago

Not a permanent one, but it should let people be able to play, which was the point of the suggestion.

db0 commented 11 years ago

It won't let people play. What is breaking is core to the game mechanics. The only way to "play" would be to drag cards manually to the table but that won't work properly for everything

kellyelton commented 11 years ago

How won't dragging cards work?

db0 commented 11 years ago

Some cards need to be placed sideways. Some effects require scripting for bluffing purposes.

db0 commented 11 years ago

Not to mention that it would be horrible to play with everything done manually.

kellyelton commented 11 years ago

Oh, I was under the assumption you could disable automations and still play. Hm

db0 commented 11 years ago

Did anything to do with shared variables change?

kellyelton commented 11 years ago

Not that I'm aware of

db0 commented 11 years ago

Was python updated?

kellyelton commented 11 years ago

No.

db0 commented 11 years ago

It definitelly has something to do with shared variables but I can't figure out what exactly.

kellyelton commented 11 years ago

Maybe the build blew something up, it failed at one point tonight, i'm re-pushing it to see if that helps.

db0 commented 11 years ago

Thanks. I'm doing some trial and error to try and understand why it's failing. It almost looks like shared variables are not being set correctly

db0 commented 11 years ago

setGlobalVariable() is storing empty dictionaries as null strings. That's bad

db0 commented 11 years ago

Did you perhaps start removing curly brackets ({}) from strings when setting global variables, the same way notify() does when displaying strings?

kellyelton commented 11 years ago

Test version just came out, try and out and see if it worked

db0 commented 11 years ago

It seems to work again in the test version. Was it what I thought? Or just caused by the error in the build?

db0 commented 11 years ago

with .204 works in normal version as well