octgn / OCTGN

Online Card and Tabletop Gaming Network
http://www.octgn.net
Other
359 stars 129 forks source link

Add superset to set.xml definition files #849

Closed GiottoVerducci closed 11 years ago

GiottoVerducci commented 11 years ago

Some games divide their expansion sets into "chapters". The expansion set name is not stored anyway, preventing from regrouping these chapters under the expansion set name.

It would be useful (and really easy) to add the expansion set name in the set definition by adding a "superSet" attribute containing the name of the super-set (to keep it generic).

This attribute would be optional.

Gravecorp commented 11 years ago

Or add it in your set def. you can sort on it in the deck editor that way as well.

On Thu, May 16, 2013 at 4:41 PM, GiottoVerducci notifications@github.comwrote:

Many of FFG LCG games divide their expansion sets into "chapters" (for A Game of Thrones, Android Netrunner) etc. The expansion set name is not stored anyway, preventing from regrouping these chapters under the expansion set name.

It would be useful (and really easy) to add the expansion set name in the set definition by adding a "superSet" attribute containing the name of the super-set (to keep it generic).

This attribute would be optional.

— Reply to this email directly or view it on GitHubhttps://github.com/kellyelton/OCTGN/issues/849 .

brine commented 11 years ago

does this have any applications outside just having another column in the deck editor? Or is it something you'd want to be able to filter for card searching? We've tossed around ideas for some sort of banlist/legal formats implementation but not sure if this request falls under that umbrella

kellyelton commented 11 years ago

Yeah I agree with graves. Also Brine, legality would be better implemented in a separate format, as opposed to this kind of superset data, at least that's how I always pictured it.

I'm going to close this unless a compelling argument arises.

brine commented 11 years ago

which is why I was asking what kind of applications it would serve.

I mean, if you want to further group sets into larger block structures, then worst case scenario is you just rename your sets into something like 'Genesis Cycle: Cyber Exodus'. This way, when you sort the database by set, they all get matched up.

db0 commented 11 years ago

Brine that wouldn't work, because you can only ever filter by one set.

kellyelton commented 11 years ago

What do you mean? You can select and filter multiple sets in the deck editor.

brine commented 11 years ago

yeah you used to not be able to search multiple sets at a time (operator was forced to AND), then a while ago we fixed it, and during the DB migration the fix was broken again,

kellyelton commented 11 years ago

I fixed it after the db migration

brine commented 11 years ago

oh I see, duh, dunno what I was doing then.

db0 commented 11 years ago

Oh yeah, right.