search

octo-technology / sonar-objective-c

Sonar Plugin for Objective C
517 stars 206 forks source link

Sonar 5.0 support #76

Closed zippy1978 closed 9 years ago

zippy1978 commented 9 years ago

Removed deprecations

zippy1978 commented 9 years ago

I have tested on:

And it runs fine... I have not tested 3.7.1

cyrilpicat commented 9 years ago

ok, thanks, I will test it on my side

cyrilpicat commented 9 years ago

Hi Gilles,

After testing it, the latest plugin works only with Sonar >= 4.3 (which is ok). I have updated the documentation to reflect this.

On another topic, I revert your change in run-sonar.sh (local directory for building) as it was not working in my sample projects. I did not took time to investigate, sorry.

Why did you make this change? The old script wasn't working in your case?

I released the plugin in that state to get some feedback from users. I am sure there will be a need for a 0.4.1 release soon anyway.

thanks a lot for your work by the way!

zippy1978 commented 9 years ago

Hi Cyril,

Nice :)

I modified the run-sonar.sh script because after enabling Sonar analysis on many projects of my company, I noticed 2 issues:

First, I noticed that the code coverage was not right because some classes where ignored by the report. And I noticed the problem did not happen on my company CI server (using xctool and gcovr as well). So, after a quick analysis : I found that the only difference was the way of building (using a local directory). I don't really know why, but using a local build directory fixed the problem.

Then, I also noticed that the xctool command failed to run tests on big projects (more than 20000 loc, and hundred of tests): it returned 1 as return code, although the test report was ok (maybe a bug with xctool). The workaround I found (not the best) was not testing return code on that command.