search

octobercms / docs

The October CMS Documentation
Other
175 stars 227 forks source link

Queued closures were deprecated in L5.3 #425

Closed scottbedard closed 3 years ago

scottbedard commented 4 years ago

Our documentation appears to be out of date with regard to queueing closures. https://octobercms.com/docs/services/queues#queueing-closures

This functionality was removed in L5.3, and appears to have been restored in L6 https://laravel.com/docs/5.3/upgrade#upgrade-5.3.0 https://laravel.com/docs/6.x/queues#queueing-closures

We should probably leave a note in the docs saying that this is no longer supported, but likely will be again when the L6 upgrade lands

daftspunk commented 4 years ago

It's been there for years and nobody has seemed to notice, it should be OK to leave it for another couple of weeks (months?) while we upgrade L6. This is certainly some more incentive to do that

LukeTowers commented 4 years ago

Note this was added back in 5.7 (https://github.com/laravel/framework/commit/556b948c41b273144e5f23f6b3b6167bf7e0c84e & https://github.com/laravel/framework/pull/25777).

daftspunk commented 3 years ago

The docs are now referring to an L6 build so we can close this. Thanks!