octobercms / install

Installation wizard for October CMS
122 stars 91 forks source link

Installation fails if password less than 4 chars #77

Closed mul14 closed 9 years ago

mul14 commented 9 years ago

This happen because of password rules on this file https://github.com/octobercms/october/blob/master/modules/backend/models/User.php#L26-L27

So, we should warn the user before installation progress fails.

dshoreman commented 9 years ago

Is there a reason you're limiting the password to 64 characters here?

mul14 commented 9 years ago

I limit the password just because modules/backend/models/User.php have password rules like this

public $rules = [
    // ..
    'password' => 'required:create|between:4,64|confirmed',
    'password_confirmation' => 'required_with:password|between:4,64'
];
dshoreman commented 9 years ago

Wasn't sure on the specific validation rules without checking, so that's fine.

I wonder whether it'd be a good idea to remove the (upper) limit at some point...

mul14 commented 9 years ago

I've tried put 100 chars password, and it fails.

We have 2 options here. Give user warning before this happen or remove the maximum password limit.

october-installation-fails-when-create-admin

daftspunk commented 9 years ago

Thanks!

daftspunk commented 9 years ago

I bumped the max values to 255 all round