octocat / Hello-World

My first repository on GitHub!
2.66k stars 2.34k forks source link

Testing reactions #349

Open octocat opened 7 years ago

octocat commented 7 years ago

Let's add some, shall we?

dmitshur-test commented 7 years ago

Is it just me, or is removeReaction mutation not working?

Edit: This issue has been fixed. removeReaction mutation works successfully for me now.

It seems to be documented completely in parallel to addReaction:

Both have the exact same input and return fields. The only difference is in the name and description.

When I do the addReaction mutation, it works as expected:

mutation AddReactionToIssue {
  addReaction(input:{subjectId:"MDU6SXNzdWUyMzEzOTE1NTE=",content:HOORAY}) {
    reaction {
      content
    }
    subject {
      id
    }
  }
}

{
  "data": {
    "addReaction": {
      "reaction": {
        "content": "HOORAY"
      },
      "subject": {
        "id": "MDU6SXNzdWUyMzEzOTE1NTE="
      }
    }
  }
}

But doing an analogous remove mutation fails with:

mutation RemoveReactionToIssue {
  removeReaction(input:{subjectId:"MDU6SXNzdWUyMzEzOTE1NTE=",content:HOORAY}) {
    reaction {
      content
    }
    subject {
      id
    }
  }
}

{
  "data": {
    "removeReaction": null
  },
  "errors": [
    {
      "message": "Could not resolve to a node with the global id of 'MDU6SXNzdWUyMzEzOTE1NTE='",
      "type": "NOT_FOUND",
      "path": [
        "removeReaction"
      ],
      "locations": [
        {
          "line": 32,
          "column": 3
        }
      ]
    }
  ]
}

Am I supposed to provide a different subjectId for remove mutation? I've tried the id and the databaseId of the reaction node itself, still same error.

rebolek commented 7 years ago

testing comment

rebolek commented 7 years ago

testing comment

rebolek commented 7 years ago

testing comment

rebolek commented 7 years ago

testing comment

rebolek commented 7 years ago

testing comment

rebolek commented 7 years ago

testing comment

rebolek commented 7 years ago

testing comment

rebolek commented 7 years ago

testing comment

rebolek commented 7 years ago

A shiny new comment! :tada:

brianamarie commented 7 years ago

HEART

AshoneA commented 7 years ago

hello

polyipseity commented 6 years ago

No comment.

maple3142 commented 6 years ago

test comment from graphiql

shujianbu commented 6 years ago

Test.

daeheonjeon commented 6 years ago

test comment!

daeheonjeon commented 6 years ago

Fantastic!

magicds commented 6 years ago

add a comment

magicds commented 6 years ago

add a comment

magicds commented 6 years ago

add another comment

zuTTers commented 6 years ago

test comment

Ausgezeichnet commented 6 years ago

@octocat Why should we react to the same words in different ways?

Shuumatsu commented 6 years ago

test

vkkis93 commented 6 years ago

it works

Ausgezeichnet commented 6 years ago

@octocat

vkkis93 commented 6 years ago

it works

PixeLInc commented 6 years ago

owo what's this? :o

boyney123 commented 6 years ago

Testing comment

jibs239 commented 5 years ago

HOORAY

jibs239 commented 5 years ago

HOORAY

jibs239 commented 5 years ago

HOORAY

jibs239 commented 5 years ago

HOORAY

jibs239 commented 5 years ago

HOORAY

jibs239 commented 5 years ago

HOORAY

jibs239 commented 5 years ago

HOORAY

jibs239 commented 5 years ago

HOORAY

jibs239 commented 5 years ago

TEST!

jibs239 commented 5 years ago

TEST!

jibs239 commented 5 years ago

TEST!

jibs239 commented 5 years ago

TEST!

jibs239 commented 5 years ago

TEST!

jibs239 commented 5 years ago

TEST!

davoodda60 commented 5 years ago

450

mirror-riddle commented 5 years ago

May the force be with you !

davoodda60 commented 5 years ago

Hi my friend

neuname commented 5 years ago

I am here but haves nothing to tell. In got a broken arm . And i am in recovery. Regards Levin Klein.

badz30 notifications@github.com schrieb am Do., 4. Apr. 2019 23:54:

badz30@o2. Please describe your issue with at least 15 characters

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/octocat/Hello-World/issues/349#issuecomment-480077708, or mute the thread https://github.com/notifications/unsubscribe-auth/AXlRCB1TDy-KxXewKE5mB3joPNujd0RKks5vdnSugaJpZM4NmmjA .

neuname commented 5 years ago

I am here but haves nothing to tell. In got a broken arm . And i am in recovery. Regards Levin Klein.

7inspire notifications@github.com schrieb am Mo., 28. Jan. 2019 10:25:

Looks good to me!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/octocat/Hello-World/issues/349#issuecomment-458053077, or mute the thread https://github.com/notifications/unsubscribe-auth/AXlRCL_narPIdHmTyedIhdN0KBzDOB3_ks5vHsILgaJpZM4NmmjA .

neuname commented 5 years ago

Hi Who is the API? ? I dont know a lot about this. Would be nice if you describe me some more clearlie. Thx . An regards Levin Klein

spaceface777 notifications@github.com schrieb am So., 26. Mai 2019 13:54:

HELLO FROM THE API

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/octocat/Hello-World/issues/349?email_source=notifications&email_token=AF4VCCCXPZ5VQXYBBSZHJL3PXJ277A5CNFSM4DM2NDAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWIEEUQ#issuecomment-495993426, or mute the thread https://github.com/notifications/unsubscribe-auth/AF4VCCFVKZZOB44JC3KRYJ3PXJ277ANCNFSM4DM2NDAA .

michaelfriedman commented 5 years ago

Bravo on the API devs.

kcfigaro commented 4 years ago

Test, Looks good to me!