Fix rare cases where CNAME and MX only contain a dot

octodns / octodns-cloudflare

Cloudflare DNS provider for octoDNS

MIT License

24 stars 18 forks source link

Fix rare cases where CNAME and MX only contain a dot #24

Closed zajdee closed 2 years ago

zajdee commented 2 years ago

Fixes #23

ross commented 2 years ago

Thanks

zajdee commented 2 years ago

Hi @ross, thank you for merging this PR.

The quotes were actually a controversial point in a discussion with my colleagues. From the two options I have picked "." to be in line with the SRV record processing. Next time I'll know. 😀

ross commented 2 years ago

The quotes were actually a controversial point in a discussion with my colleagues. From the two options I have picked "." to be in line with the SRV record processing. Next time I'll know. 😀

Heh. Not a big deal either way. It does look like this module uses " in places anyway. Something I wish pycodestyle (in the past) or black (now) dealt with one way or another so that humans didn't have to think about it :grin: