octodns / octodns-constellix

Constellix DNS provider for octoDNS
MIT License
1 stars 4 forks source link

Update to match latest template details #6

Closed ross closed 2 years ago

ross commented 2 years ago

No meaningful changes, just template sourced updates.

viranch commented 2 years ago

It would be nice to have an automatic way to update all providers whenever the template changes.

ross commented 2 years ago

It would be nice to have an automatic way to update all providers whenever the template changes.

I have a helper script that I'm using here called look-for-changes that essentially generates a new skeletal provider with all the original parameters and then diffs them. It still ends up being a bit of manual work to go through and make the specific changes, but atm I'm not seeing a way to fully automate it as there are enough changes after the original generation that it may be flakey. Some of the bits in the template are TODO/placeholder which is the real problem.

I plan to commit the helper script as-is to octodns-template once this pass it done (its test.)

I may play around with trying to turn the current diff bit into a patch and applying it, but atm it'll run into problems with the TODOs/placeholder bits and files like requirements.txt which are minimal in the template. No clue if that'll work out or not.

istr commented 2 years ago

@ross you might want to have a look into https://github.com/solvaholic/template / https://github.com/solvahol/dns and the mechanisms used there to get a template repo in sync. Just stumbled upon it recently, see https://github.com/solvaholic/octodns-sync/issues/86. Disclaimer: I did not yet try it out myself and can't tell if the solution is feasible at all. Just some food for thought.

viranch commented 2 years ago

@istr interesting I just noticed the "generated from" badge, I was not aware of native repo templating in Github. May be something we could use for all octodns-* provider repos.