search

octodns / octodns-ns1

Ns1Provider provider for octoDNS
MIT License
4 stars 13 forks source link

Don't fail on unsupported tier > 1 records in populate #18

Closed ross closed 2 years ago

ross commented 2 years ago

Not all records have short_answers so we need to avoid the KeyError on those that don't. This also adds a test case from the problematic record provided in https://github.com/octodns/octodns-ns1/issues/17 and fixes some ~bugs in the existing test code where answers weren't what they were expected to be (likely copy-n-paste errors.)

/cc https://github.com/octodns/octodns-ns1/issues/17 @flz

ross commented 2 years ago

A "safe" change, avoids an exception on the (rare) case there's no short_answers in the record data.