v0.0.4 version bump & changelog update

octodns / octodns-ns1

Ns1Provider provider for octoDNS

MIT License

4 stars 13 forks source link

Closed ross closed 1 year ago

ross commented 1 year ago

Dynamic records filter chain ordering reworked to place country filters before regions, see https://github.com/octodns/octodns-ns1/pull/37 for details/discussion.
AS implemented as a list of countries rather than the ASIAPAC region which didn't match as the AS list of countries in the first place
AS, NA, and OC source their list of countries from octodns.record.geo_data rather than manually duplicating the information here.
Add TL to the list of special case countries so that it can be individually targeted
Fix for rule ordering when there's > 10 rules
Fixed persistent change issue with dynamic records after the API started returning new fields under config

/cc @istr @viranch going to let this one sit for a bit since there's some fairly meaningful fixes/changes.

istr commented 1 year ago

@ross Great! Thank you for addressing the issues fixed with this release so thoroughly and quickly.

viranch commented 1 year ago

It will be nice to sneak #45 in this release.

ross commented 1 year ago

It will be nice to sneak #45 in this release.

Was it changelog worthy or we fine with shipping it w/o the mention?

viranch commented 1 year ago

It will be nice to sneak #45 in this release.

Was it changelog worthy or we fine with shipping it w/o the mention?

Good point, I think it should be mentioned. Would you prefer I add it in this PR's branch or raise a separate PR?

ross commented 1 year ago

This PR is fine. Changlog updates in a release PR are fair game

istr commented 1 year ago

Thank you, @ross and @viranch for moving this forward. Hopefully the M&A on the horizon will not render ns1 defunct... :see_no_evil: https://newsroom.ibm.com/IBM-Plans-to-Acquire-NS1-to-Help-Enterprises-Drive-Network-Agility-in-their-Hybrid-Cloud-Environments

ross commented 1 year ago

Hopefully the M&A on the horizon will not render ns1 defunct... 🙈

A person formerly in an exec role in a slack I'm in said they think everything is headed in the right direction and they'll be good stewards 🤞.

Otherwise you all feel like we are good to go here?

viranch commented 1 year ago

Otherwise you all feel like we are good to go here?

Let me add the changelog entry here ~soon, unless you beat me to it, then we can ship!

ross commented 1 year ago

Let me add the changelog entry here ~soon, unless you beat me to it, then we can ship!

Oh. My bad, for some reason thought that had already come through. Fine with holding for it.

viranch commented 1 year ago

@ross good to go!

ross commented 1 year ago