Don't log.exception on 404s, noisy when zones are being created

octodns / octodns-ns1

Ns1Provider provider for octoDNS

MIT License

4 stars 13 forks source link

Don't log.exception on 404s, noisy when zones are being created #72

Closed ross closed 10 months ago

ross commented 10 months ago

In testing unrelated stuff locally I noticed that ResourceExceptions are thrown for 404s, i.e. when a zone doesn't exist and needs to be created. That makes for a really noisy and slightly scary log output for a normal use case. This code updates things so that 404s don't log.

/cc https://github.com/octodns/octodns-ns1/pull/71 @jdickson0296

jdickson0296 commented 10 months ago

I see that makes sense, thanks for the update.