ali-tny commented 4 years ago

I went through the changes for anything relevant to timeserio. The main problem (in timeserio/preprocessing/pandas.py) was caught by a test (wahoo)

Tests will fail due to the version test, which is fixed in https://github.com/octoenergy/timeserio/pull/10. Will rebase this once that PR is merged.

ig248 commented 4 years ago

That's great @ali-tny , thanks for checking pandas changes!

ali-tny commented 4 years ago

weird.. tests ran locally (w/ the version changes - i assumed the failure was from that) i'll check it out yeah

ali-tny commented 4 years ago

ah, looks like some intermittent pytest problem, reran the workflow and it fails at the version test as expected

codecov-io commented 4 years ago

Codecov Report

Merging #11 into master will increase coverage by <.01%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
+ Coverage   88.86%   88.86%   +<.01%     
==========================================
  Files          34       34              
  Lines        1643     1644       +1     
==========================================
+ Hits         1460     1461       +1     
  Misses        183      183

Impacted Files	Coverage Δ
timeserio/preprocessing/pandas.py	`89.15% <100%> (ø)`	:arrow_up:
timeserio/data/mock.py	`95.91% <100%> (+0.08%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b64d59c...559b0ea. Read the comment docs.

octoenergy / timeserio

Update to pandas v1.0 #11

Codecov Report