search

octoenergy / timeserio

Better `keras` models for time series and beyond
MIT License
61 stars 16 forks source link

Add `country` keyword argument for is_holiday #21

Closed ali-tny closed 4 years ago

ali-tny commented 4 years ago

Specify which country's holidays you want:

PandasDateTimeFeaturizer(
    column=date_col, attributes=["is_holiday"], kwargs=dict(country="England")
)

Default remains as before, so not setting kwargs returns UK holidays.

codecov-commenter commented 4 years ago

Codecov Report

Merging #21 into master will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #21   +/-   ##
=======================================
  Coverage   88.80%   88.80%           
=======================================
  Files          34       34           
  Lines        1661     1662    +1     
=======================================
+ Hits         1475     1476    +1     
  Misses        186      186
Impacted Files Coverage Δ
timeserio/preprocessing/datetime.py 96.89% <100.00%> (+0.02%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5e4cbce...462a848. Read the comment docs.