search

octoenergy / timeserio

Better `keras` models for time series and beyond
MIT License
61 stars 16 forks source link

Compatibility with latest scikit-learn #23

Closed ig248 closed 3 years ago

codecov-commenter commented 4 years ago

Codecov Report

Merging #23 into master will decrease coverage by 0.13%. The diff coverage is 82.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
- Coverage   88.81%   88.68%   -0.14%     
==========================================
  Files          34       34              
  Lines        1690     1723      +33     
==========================================
+ Hits         1501     1528      +27     
- Misses        189      195       +6
Impacted Files Coverage Δ
timeserio/preprocessing/utils.py 84.00% <81.81%> (-4.24%) :arrow_down:
timeserio/preprocessing/encoding.py 87.87% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 83514f6...c9f6011. Read the comment docs.

ig248 commented 4 years ago

@ali-tny you are right, this is exactly the route sklearn took. I am OK to remove the transform_selected logic in the future.