search

octoenergy / timeserio

Better `keras` models for time series and beyond
MIT License
61 stars 16 forks source link

Enforce scikit-learn > 0.20.3 #24

Closed ali-tny closed 3 years ago

ali-tny commented 3 years ago

In timeserio/preprocessing/utils.py:

from sklearn.utils.fixes import _astype_copy_false

This isn't available for scikit-learn 0.20.3:

>>> import sklearn; sklearn.__version__
'0.20.3'
>>> from sklearn.utils.fixes import _astype_copy_false
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: cannot import name '_astype_copy_false'

but all good for 0.23.1:

>>> import sklearn; sklearn.__version__
'0.23.1'
>>> from sklearn.utils.fixes import _astype_copy_false
>>>
codecov-commenter commented 3 years ago

Codecov Report

Merging #24 into master will increase coverage by 63.90%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #24       +/-   ##
===========================================
+ Coverage   24.78%   88.68%   +63.90%     
===========================================
  Files          34       34               
  Lines        1723     1723               
===========================================
+ Hits          427     1528     +1101     
+ Misses       1296      195     -1101
Impacted Files Coverage Δ
timeserio/version.py 89.58% <0.00%> (+4.16%) :arrow_up:
timeserio/keras/callbacks.py 98.00% <0.00%> (+19.00%) :arrow_up:
timeserio/externals.py 88.88% <0.00%> (+22.22%) :arrow_up:
timeserio/utils/pickle.py 100.00% <0.00%> (+50.00%) :arrow_up:
timeserio/batches/chunked/pandas.py 72.46% <0.00%> (+72.46%) :arrow_up:
timeserio/multimodel/base.py 83.14% <0.00%> (+83.14%) :arrow_up:
timeserio/preprocessing/utils.py 84.00% <0.00%> (+84.00%) :arrow_up:
timeserio/validation/validation.py 86.48% <0.00%> (+86.48%) :arrow_up:
timeserio/preprocessing/encoding.py 87.87% <0.00%> (+87.87%) :arrow_up:
timeserio/pipeline/multipipeline.py 88.88% <0.00%> (+88.88%) :arrow_up:
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d2da543...851e5b7. Read the comment docs.

ali-tny commented 3 years ago

looks like theres something funky going on w testing & with circleci reporting - will fix before merging