octokatherine / readme.so

An online drag-and-drop editor to easily build READMEs
https://readme.so
MIT License
4.24k stars 326 forks source link

Some sections disappeared after reset #180

Closed theilgaz closed 3 years ago

theilgaz commented 3 years ago

I added some sections from available list, then I clicked reset button. Some sections disappeared.

added

Here is the section list after reset operation:

21

octokatherine commented 3 years ago

@theilgazcode this is actually the intended behavior. The reset button returns the page to the default state, with only the "Title and description" section selected.

I'd be curious to hear what you expected to happen, and if there's anything you think we could do to make this more clear

theilgaz commented 3 years ago

@theilgazcode this is actually the intended behavior. The reset button returns the page to the default state, with only the "Title and description" section selected.

I'd be curious to hear what you expected to happen, and if there's anything you think we could do to make this more clear

I mean Github Profile sections disappeared after reset.

jose-vale commented 3 years ago

This issue was resolved in #166 but the fix seems to have been reverted in #135. If necessary I can reapply the fix.

rishabhrathod01 commented 3 years ago

Here while resolving merge conflicts, I by-mistake reverted the above-mentioned #166 fix. It was unintentional.

jose-vale commented 3 years ago

Here while resolving merge conflicts, I by-mistake reverted the above-mentioned #166 fix. It was unintentional.

No worries, I'll just resubmit the PR.