search

octokatherine / readme.so

An online drag-and-drop editor to easily build READMEs
https://readme.so
MIT License
4.24k stars 326 forks source link

Deleting a section does not clear changes #189

Closed jose-vale closed 3 years ago

jose-vale commented 3 years ago

See attached gif. Will work on the fix.

example

octokatherine commented 3 years ago

I'm honestly not sure what the expected behavior would be here. My concern with this is a user accidentally clicking the trash icon and losing their work

jose-vale commented 3 years ago

That's a good point. Do you think that it would be a better experience if the state was maintained on delete, but next to the delete button there was a restore option (or anywhere else)? Currently the only way to get the original templates is to do a full reset.

octokatherine commented 3 years ago

I like that idea! I think we should add the reset circular arrow (same icon as above) next to the delete icon, and make sure it asks for confirmation before resetting the section

jose-vale commented 3 years ago

Will add that icon as soon as I can.

jose-vale commented 3 years ago

@octokatherine I implemented the discussed changes, let me know if there is anything you don't agree with.