Little fixes/refactoring

AlperBayraktar commented 2 years ago

Theme toggler in navbar also should be visible while not editing md.
Added title to theme toggler.
Made navbar image alts' text color white to make them visible.
In development, images doesn't load when language is not English. Added a '/' to start of image hrefs to fix that.

Saw this error in dev (editor page, dark mode enabled):

readme so fixed error

Reason: Since there is no window object in server load, theme is 'light' and editor's theme toggle image's alt is light. But when client page loads, window becomes defined so alt is set to 'dark'. So next throws this error because server and client pages are not same.

Fix: Load theme as light in server, and load the actual theme when page loads (when window gets defined).

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
readme-so	✅ Ready (Inspect)	Visit Preview	Sep 5, 2022 at 7:47PM (UTC)

Anas-Dew commented 1 year ago

Good one

octokatherine / readme.so

Little fixes/refactoring #259