octokit / app.js

GitHub Apps toolset for Node.js
MIT License
158 stars 34 forks source link

fix(types): export minimal types required for the `App` class #536

Closed wolfy1339 closed 6 months ago

wolfy1339 commented 6 months ago

This resolves issues in consumers of this package getting errors from TypeScript

The inferred type of 'App' cannot be named without a reference to '../node_modules/@octokit/app/dist-types/types.js'. This is likely not portable. A type annotation is necessary.

Resolves #ISSUE_NUMBER


Before the change?

After the change?

Pull request checklist

Does this introduce a breaking change?

Please see our docs on breaking changes to help!


github-actions[bot] commented 6 months ago

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

github-actions[bot] commented 6 months ago

:tada: This PR is included in version 15.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: