fix: follow up hotpath test

octokit / core.js

Extendable client for GitHub's REST & GraphQL APIs

MIT License

1.19k stars 310 forks source link

Closed Uzlopak closed 11 months ago

Uzlopak commented 11 months ago

@gr2m @wolfy1339

As requested here the "fixed" unit test. Because I bind the console methods very early, I needed to change the tests.

Resolves #ISSUE_NUMBER

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)

Please see our docs on breaking changes to help!

Uzlopak commented 11 months ago

@gr2m Should I create an issue for this PR? Or will you merge it anyway? Is the policy very strict?

wolfy1339 commented 11 months ago

It isn't always necessary for an issue, especially when things are self explanatory. It's always better to make one especially for features

Uzlopak commented 11 months ago

@wolfy1339

can we merge this, and then make an overall update of all deps for probot?

github-actions[bot] commented 11 months ago

:tada: This PR is included in version 5.0.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: