search

octokit / core.js

Extendable client for GitHub's REST & GraphQL APIs
MIT License
1.19k stars 310 forks source link

Update index.ts with OctokitOptions export #646

Closed mcgear closed 9 months ago

mcgear commented 10 months ago

Resolves #645

Before the change?

OctokitOptions is not currently exported for use in strong typing solutions.

-

After the change?

OctokitOptions is exported from index.ts

-

Pull request checklist

N/A

Does this introduce a breaking change?

No breaking changes

Please see our docs on breaking changes to help!

github-actions[bot] commented 10 months ago

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

nickfloyd commented 9 months ago

Hey @mcgear Let us know what you think about @wolfy1339's suggestion and once confirmed we can get this merged in and released. Thanks for the commits here ❤️ .

mcgear commented 9 months ago

Sorry about that, i put that in.

wolfy1339 commented 9 months ago

Can you also merge the latest changes from the main branch?

mcgear commented 9 months ago

Done

github-actions[bot] commented 9 months ago

:tada: This PR is included in version 5.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 7 months ago

:tada: This PR is included in version 5.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: