octokit / core.js

Extendable client for GitHub's REST & GraphQL APIs
MIT License
1.19k stars 310 forks source link

fix(pkg): add main entry point #662

Closed deniak closed 8 months ago

deniak commented 8 months ago

Before the change?

Now that the package is ESM, eslint may return the following errors:

error  Unable to resolve path to module '@octokit/core'  import/no-unresolved
error  "@octokit/core" is not found                      node/no-missing-import

After the change?

eslint should no longer report the errors

Pull request checklist

Does this introduce a breaking change?

Please see our docs on breaking changes to help!


github-actions[bot] commented 8 months ago

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

wolfy1339 commented 8 months ago

I wonder why that is.

Shouldn't the export field be enough?

deniak commented 8 months ago

I wonder why that is.

Shouldn't the export field be enough?

I thought so too, but eslint started complaining after the upgrade to 6.0.0 :(

wolfy1339 commented 8 months ago

Can you add the type parameter as well for good measure

deniak commented 8 months ago

Can you add the type parameter as well for good measure

You mean the "type": "module"? Isn't it there already (https://github.com/octokit/core.js/blob/main/package.json#L7)?

wolfy1339 commented 8 months ago

Sorry, I meant types

deniak commented 8 months ago

Sorry, I meant types

Sure, I just committed the update.

github-actions[bot] commented 8 months ago

:tada: This PR is included in version 6.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

deniak commented 8 months ago

Thanks @wolfy1339