build(deps): replace `@gr2m/fetch-mock` with `fetch-mock`

octokit / core.js

Extendable client for GitHub's REST & GraphQL APIs

MIT License

1.18k stars 307 forks source link

build(deps): replace `@gr2m/fetch-mock` with `fetch-mock` #686

Closed wolfy1339 closed 3 months ago

wolfy1339 commented 3 months ago

Before the change?

Used a custom fork of fetch-mock for Fetch API support

After the change?

Use the fetch-mock module again, it has been updated to support the Fetch API

Pull request checklist

[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

[ ] Yes
[x] No

github-actions[bot] commented 3 months ago

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

wolfy1339 commented 3 months ago

The tests are failing because of some type errors with fetch-mock, otherwise the tests are passing

oscard0m commented 3 months ago

The tests are failing because of some type errors with fetch-mock, otherwise the tests are passing

Are these type errors something we can fix on our end or it needs work in fetch-mock?

wolfy1339 commented 3 months ago

Are these type errors something we can fix on our end or it needs work in fetch-mock?

These type errors are not because of our code. We could always override the types, but that's not a great way to do it over the 50 repositories that use fetch-mock.

See this PR https://github.com/wheresrhys/fetch-mock/pull/680

It's because the package offers CJS+ESM but the types only have a CJS export and this TypeScript complains that there is no default export defined.

The problem has been fixed, just waiting for the release to drop on npm

wolfy1339 commented 3 months ago

This is now ready to merge