search

octokit / discussions

discussions and planning for Octokit clients
7 stars 5 forks source link

How to handle "ENOTFOUND api.github.com" responses #25

Closed gr2m closed 5 years ago

gr2m commented 5 years ago

I’m looking into implementing best practises right into octokit.js as much as possible, like limiting mutating requests to 1 per second by default.

When I looked into the logs of the WIP app, I’ve found that while there are plenty "You have triggered an abuse detection mechanism" errors, there are many more errors like this

request to https://api.github.com/repos/gr2m/sandbox/statuses/b2d29b79ad66e9fc589e0c9f73319b2f5293d4fa failed, reason: getaddrinfo ENOTFOUND api.github.com api.github.com:443

image

Is that something any of you encountered before? Might it be a problem with now? Would you implement a retry for that error directly into the library?

bkeepers commented 5 years ago

ENOTFOUND is a DNS resolution error. I have rarely seen it in the apps I operate. I would definitely contact Zeit about it.