octokit / dotnet-sdk

MIT License
54 stars 8 forks source link

[FEAT]: Friendly API for uploading release assets #27

Open alexrp opened 8 months ago

alexrp commented 8 months ago

Describe the need

I might have missed it, but there doesn't appear to be a friendly API for uploading release assets. In Octokit, this was done like so:

var releaseApi = ghc.Repository.Release;
var release = await releaseApi.Get(...);
await releaseApi.UploadAsset(release, new ReleaseAssetUpload(zipFileName, MediaTypeNames.Application.Zip, stream, timeout));

It would be nice if Octokit.NET.SDK had something similar rather than requiring me to make a manual request using the Release.UploadUrl.

SDK Version

v0.0.3

API Version

No response

Code of Conduct

github-actions[bot] commented 8 months ago

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

nickfloyd commented 7 months ago

Hey @alexrp,

Thanks for reaching out. You're touching on an aspect of the generated SDKs that we will be addressing in the months to come. Composite SDKs. We will be leaning more into these as we get use cases from the community and gather all of our leanings from the more than a decade of learning on our existing SDKs.

Thank you for highlighting this use case! We'll add it to the others that we're planning on having a look at implementing. With that said, we would be more than glad to get a PR from you and others on how this might look as an implementation in this new SDK!

alexrp commented 1 month ago

Hey, just wanted to check in and ask if you've had a chance to think on this one? :eyes: