FEAT: Initial design of the rate limit handler - Githubissues

octokit / dotnet-sdk

MIT License

52 stars 8 forks source link

FEAT: Initial design of the rate limit handler #51

Closed nickfloyd closed 2 months ago

nickfloyd commented 4 months ago

This PR adds rate-limiting awareness (of both primary and secondary rate limits) to the dotnet-sdk. It has been validated against local versions of github/github. Note that it does not change any abstractions used to access the SDK client as https://github.com/octokit/go-sdk/pull/52 did. Coverlet gives unit testing coverage of 98% of lines and 83% of branches.

Before the change?

The dotnet SDK did not handle the rate limiting pattern returned from the REST API

After the change?

The SDK now handles primary and secondary rate limits.

Pull request checklist

[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

[ ] Yes
[x] No

github-actions[bot] commented 4 months ago

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀