search

octokit / dotnet-sdk

MIT License
54 stars 8 forks source link

int32 overflow deserializing generated models #98

Closed martincostello closed 1 month ago

martincostello commented 1 month ago 
          @kfcampbell Sorry, it's still broken. Looks like the exact property I have an issue with escaped the changes:

https://github.com/octokit/dotnet-sdk/blob/e4bb0f0bf57a34ed2fcc8b9911c5eb536e90a650/src/GitHub/Models/EnvironmentObject.cs#L34

Originally posted by @martincostello in https://github.com/octokit/dotnet-sdk/issues/95#issuecomment-2208249482

github-actions[bot] commented 1 month ago

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

kfcampbell commented 1 month ago

Good catch, thanks @martincostello! I'm working on pushing some changes through internally that should fix this.

martincostello commented 1 month ago

Resolved by #101.