search

octokit / go-octokit

Simple Go wrapper for the GitHub API
https://github.com/octokit/go-octokit
MIT License
258 stars 79 forks source link

Adding label endpoints #124

Closed half-ogre closed 8 years ago

half-ogre commented 8 years ago

This PR adds all the label endpoints.

TODO

half-ogre commented 8 years ago

@pengwynn: Do y'all have any interest in me adding end-to-end tests for the endpoints I'm adding that actually hit the API, and that are only run conditionally based on an environment variable?

pengwynn commented 8 years ago

@half-ogre Thanks for working through these. :sparkling_heart: Would have gotten back sooner, but I was off the grid. :tent:

Do y'all have any interest in me adding end-to-end tests for the endpoints I'm adding that actually hit the API, and that are only run conditionally based on an environment variable?

Not quite sure I follow. It looks like you've wired up tests with the same pattern the other methods use, right?

half-ogre commented 8 years ago

@pengwynn This PR is ready for review.

Not quite sure I follow. It looks like you've wired up tests with the same pattern the other methods use, right?

I was talking about adding acceptance tests in addition to the unit tests, that actually hit the live API, but the friction and amount of change this would add makes this not something to talk about in the context of this PR, even if you were interested. So, never mind. :)

Tonkpils commented 8 years ago

:+1: looking forward to these changes

pengwynn commented 8 years ago

@half-ogre thanks for the patch! I saw some whitespace/alignment issues (maybe mix of tabs/spaces?). Once we fix those up this looks good. :+1:

half-ogre commented 8 years ago

I saw some whitespace/alignment issues (maybe mix of tabs/spaces?

My bad. I ran go fmt and all should be well now.

pengwynn commented 8 years ago

:cake: