search

octokit / go-octokit

Simple Go wrapper for the GitHub API
https://github.com/octokit/go-octokit
MIT License
258 stars 79 forks source link

Point to a fork of lostisland/go-sawyer #64

Closed owenthereal closed 9 years ago

owenthereal commented 9 years ago

Code changes from the latest master of lostisland/go-sawyer hasn’t been applied to octokit/go-octokit, causing compilation errors. The current approach of providing a wrapper script to bootstrap the library is confusing (see #62). It also makes using the library harder (we need to vendor to a particular commit, see https://github.com/github/hub/blob/gh/Godeps/Godeps.json#L57-L60).

Let’s point to the fork jingweno/go-sawyer for now which doesn’t include the latest breaking changes from lostisland/go-sawyer and unblock the mentioned issues.

/cc @technoweenie @pengwynn @mislav

pengwynn commented 9 years ago

Code changes from the latest master of lostisland/go-sawyer hasn’t been applied to octokit/go-octokit

@jingweno Other than time being scarce, are we blocked on getting those changes applied? Is there a discussion for it?

owenthereal commented 9 years ago

@pengwynn I'm not aware of other blockers other than I need a bit more time to update to the latest go-sawyer. I'm busy with helping push hub 2.x out the door - it involves adding more APIs on go-octokit, e.g., https://github.com/github/hub/pull/601. Pointing to a fork that is locked to an early go-sawyer would put go-octokit to a more stable state and make it easier to vendor dependencies in hub with godep. I'll come back upgrading to the latest go-sawyer.

Regarding to discussion, @technoweenie pinged me a while ago about the breaking changes. I just didn't have the time to look into it.

technoweenie commented 9 years ago

Ha, didn't you ask me to just merge it? Sorry for causing problems :/

owenthereal commented 9 years ago

@technoweenie Yes I did. Please don't take this as a blame though and no need to be sorry. The problem comes from my end - I didn't spend enough time with octokit and now we need a stable octokit with more API support, see https://github.com/octokit/go-octokit/pull/65 and https://github.com/octokit/go-octokit/pull/66. Pointing it to a fork would be the best approach for now since octokit and sawyer could evolve in different paces. I'll come back to adopt the latest sawyer API later.