search

octokit / go-octokit

Simple Go wrapper for the GitHub API
https://github.com/octokit/go-octokit
MIT License
258 stars 79 forks source link

[WIP] Service refactoring proof of concept #85

Closed dhruvsinghal closed 9 years ago

dhruvsinghal commented 9 years ago

Continues refactoring started in #83 @pengwynn, @lalalah

pengwynn commented 9 years ago

@jingweno What do you think about this direction?

The tldr; is: I'd like to move the link relation to a param on the method instead of a field on the struct since services can provide a number of API methods.

owenthereal commented 9 years ago

@pengwynn LGTM :+1:

dannysperling commented 9 years ago

I fixed the renaming of e to err - several places it wasn't changed, which was causing the code to not compile. In doing this, it claims I merged in the service-refactoring-proof-of-concept branch into itself. As far as I can tell, that commit didn't actually change the code it says it does, as those changes were already in the branch. I'm a little confused by what happened here and whether I only made the fixes in commit c6360d9 as desired or if the commit a05609b actually changed code.

pengwynn commented 9 years ago

@dannysperling Thanks for fixing that. The diff is also showing merges I don't recall making, too. I'm about to hop in a :car: and drive to Austin for SXSW, but I'll take a look this evening.