octokit / go-octokit

Simple Go wrapper for the GitHub API
https://github.com/octokit/go-octokit
MIT License
258 stars 79 forks source link

Add Followers API #89

Closed obsc closed 9 years ago

obsc commented 9 years ago

@pengwynn

Added functionality for https://developer.github.com/v3/users/followers/ Also added booleans as an additional return just as we discussed.

pengwynn commented 9 years ago

@obsc I dig the boolean returns. How would you feel about updating it to match the new approach we're pioneering over in https://github.com/octokit/go-octokit/pull/85 where each method takes a hyperlink instead of having a field on the service?

obsc commented 9 years ago

@pengwynn Refactored to the new approach in #85.

One issue that might need addressing is

if err != nil {
    return nil, &Result{Err: err}
}

is never called upon testing atm. Should I add failure tests that try to expand a broken hyperlink to hit 100% test coverage?

pengwynn commented 9 years ago

Should I add failure tests that try to expand a broken hyperlink to hit 100% test coverage?

That sounds awesome and would make @dannysperling really happy.

obsc commented 9 years ago

@pengwynn Fixed tests to include a failure test now.

pengwynn commented 9 years ago

:sparkles: Thanks!