octokit / go-sdk

A generated Go SDK from GitHub's OpenAPI specification. Built on Kiota.
MIT License
64 stars 7 forks source link

Introduce linting #34

Closed kfcampbell closed 6 months ago

kfcampbell commented 6 months ago

This PR adds linting to the project with a configuration derived from an internal project. I've added script/lint.sh for local invocations and .github/workflows/lint.yml for PR invocations. As a bonus, we should see annotations on our PRs when linting errors are introduced.

I've had to ignore one error in our generated code: in pkg/github/markdown/raw_request_builder.go, this line does not check for errors when executing. As this is an upstream Kiota issue, I've chosen to ignore it for now.

github-actions[bot] commented 6 months ago

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

what-the-diff[bot] commented 6 months ago

PR Summary