search

octokit / go-sdk

A generated Go SDK from GitHub's OpenAPI specification. Built on Kiota.
MIT License
56 stars 7 forks source link

Spelling #41

Closed jsoref closed 4 months ago

jsoref commented 4 months ago

Before the change?

After the change?

Pull request checklist

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

github-actions[bot] commented 4 months ago

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

nickfloyd commented 4 months ago

Hey @jsoref thank you for the work here! The files that you changed are generated. So if these changes were applied the would be overwritten the next time generation ran. You can submit an issue to the descriptions repo so that the teams who own the OpenAPI descriptions can make the changes you're suggesting.

Sorry for the trouble here - but if you link your PR here to your issue then the teams will be able to get these changes in permanently.

kfcampbell commented 4 months ago

Hi @jsoref, thanks for the interest! For this project, please keep changes out of the pkg/github directory, since those are generated from GitHub's OpenAPI spec and any manual fixes would be wiped out on the next generation. I'm going to close this PR but please feel free to follow up if you have any questions.