octokit / graphql-action

A GitHub Action to send queries to GitHub's GraphQL API
https://github.com/marketplace/actions/github-graphql-api-query
MIT License
125 stars 24 forks source link

attempt to fix build #255

Open kfcampbell opened 9 months ago

kfcampbell commented 9 months ago

Work-in-progress experiments to fix the broken builds on this repo.

This PR:

github-actions[bot] commented 9 months ago

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

gr2m commented 9 months ago

I would recommend to use https://github.com/actions/create-github-app-token/ as a reference, that's how I'd setup actions these days. esbuild creates much more readable build files, is faster, and simpler. And as actions support Node 20 now, we can use ES Modules.

wolfy1339 commented 7 months ago

This is odd... The same tests work locally for me

wolfy1339 commented 7 months ago

Bumping it to use the NodeJS 20 runner fixed things.

The problem is that undici requires NodeJS >= 18 as of now: https://github.com/nodejs/undici/blob/v6.13.0/package.json#L128

Undici was introduced via @octokit/action v6