search

octokit / octokit.graphql.net

A GitHub GraphQL client library for .NET
MIT License
143 stars 49 forks source link

Share authorization with octokit.net #280

Open MatisseHack opened 1 year ago

MatisseHack commented 1 year ago

I need to use both octokit.net and octokit.graphql.net in the same project and I wish I could more easily share authorization tokens between both SDKs. I've written an ICredentialStore to cache and refresh authorization tokens, but this interface is slightly different between octokit.net and octokit.graphql.net, which complicates the implementation unnecessarily.

It's a pretty minor issue, but I wish these two packages worked together more seamlessly. One possible solution would be to extract authorization related code into a separate package that both projects could depend on. Such a change might also help address #128

nickfloyd commented 1 year ago

Hey @MatisseHack,

This is one of the future design changes we hope to make as we begin leaning into generative SDKs - we'd like to abstract things such as models, auth, caching, throttling, and the like, which could easily be referenced in, as you suggest. We've got a little ways to go to get things moving in that direction, but until then, please join the discussion here and here - we'd love to have your voice and thoughts woven into the future of what this might all look like in the future.

MatisseHack commented 1 year ago

Great to hear it's already on the radar! I'll chime in there if I can think of anything to add. Thanks