Fix GraphQL entity names in subqueries

jMarkP commented 1 year ago

Resolves #298

Behavior

Before the change?

Described in #298. When generating the GraphQL for subqueries, the query builder uses the C# type name, not the GraphQL entity type

After the change?

The model generator now emits the [GraphQLIdentifier(...)] attribute on all generated interfaces and stubs, and this gets read by GetIdentifier when generating the GraphQL syntax.

Other information

I also regenerated the model from the schema. The first commit on this PR is just that straight-up regeneration. The other commits fix the issue.

Additional info

Pull request checklist

[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)
[ ] Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

[ ] Yes (Please add the Type: Breaking change label)
[x] No

If Yes, what's the impact:

N/A

Pull request type

Please add the corresponding label for change this PR introduces: - Bugfix: `Type: Bug` - Feature/model/API additions: `Type: Feature` - Updates to docs or samples: `Type: Documentation` - Dependencies/code cleanup: `Type: Maintenance` ----

kfcampbell commented 1 year ago

@jMarkP do you have thoughts about the testing errors we're seeing here?

jMarkP commented 1 year ago

@kfcampbell thanks for kicking that off. Ah looks like I must have missed that class of tests when I ran locally. Will add a fix next time I have a chance.

jMarkP commented 1 year ago

@kfcampbell - have managed to fix the unit tests - turned out to be a simple fix!

jMarkP commented 1 year ago

Thank you @jMarkP! We appreciate the contributions.

You're welcome! Thanks for the merge

octokit / octokit.graphql.net