search

octokit / octokit.graphql.net

A GitHub GraphQL client library for .NET
MIT License
145 stars 50 forks source link

Update dependencies and cleanup projects #304

Open 0xced opened 1 year ago

0xced commented 1 year ago
kfcampbell commented 8 months ago

I'm interested in picking this up, as I'm looking at #312 but also want to update other aspects of the library. To avoid stomping on your branch/fork any further, I'll create a separate PR.

0x5bfa commented 2 months ago

@Lamparter i think we've already worked this in our PR right?

Lamparter commented 2 months ago

@Lamparter i think we've already worked this in our PR right?

Yes I think so. I definitely did do 1st (obviously) and I remember fixing the 4th task also. But not sure whether or not I implemented 2nd and 3rd.

  • Update test projects from .NET Core 3.1 (out of support) to .NET 6 (LTS)
  • Remove <Service Include="{82a7f48d-3b50-4b1e-b82e-3ada8210c358}" /> (see https://github.com/microsoft/vstest/issues/472#issuecomment-378811616)
  • Remove <LangVersion>7.2</LangVersion> on test projects
  • Fix Run_Specifies_Cancellation_Token which (rightfully) throws when running on .NET 6
0x5bfa commented 1 week ago

321 supersedes this PR, @Lamparter we seem to haven't implemented the 4th and sounds like we should separate.

Lamparter commented 1 week ago

Separate?

0x5bfa commented 1 week ago

Instead of including that change in #321

Lamparter commented 1 week ago

Where would we include that change instead?

0x5bfa commented 1 week ago

A new PR or here (with other changes reverted as superseded by our PR).

Lamparter commented 1 week ago

This isn't our pr though. I think it's best to just leave in one pr.