search

octokit / octokit.graphql.net

A GitHub GraphQL client library for .NET
MIT License
144 stars 50 forks source link

Code Quality: Simplify directories #323

Closed Lamparter closed 1 week ago

Lamparter commented 3 weeks ago

Related: #293 (hey there!) This pull request was authored on behalf of @RiversideValley

Before the change?

After the change?

Pull request checklist

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

No

Hello (for the third time) 😁 In this PR, I (on behalf of @0x5bfa) have simplified the root directory/subdirectories to match common practices on GitHub. Took a while to get the configuration right, but everything builds correctly and packages are references as they should be. :octocat:

github-actions[bot] commented 3 weeks ago

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

Lamparter commented 2 weeks ago

Thanks for the review! Most of these change I've implemented (readme, src dir, net8.0) were suggested by the kind @0x5bfa so thank him for having lots of ideas for this project! ❤️ (you'll notice most of our changes are in our collaboration repo RiversideValley/Octokit) I've mainly focused on .NET 8 in #321 so unless you want me to bring those changes here I'll keep these PRs separate 😅 I'll make sure to implement what you've requested and I'll run the source generator as well. 😁

nickfloyd commented 2 weeks ago

I've mainly focused on .NET 8 in #321 so unless you want me to bring those changes here I'll keep these PRs separate 😅

Keep it there, I think that's the right move unless you run into anything that would prevent you from keeping them separate.

I'll make sure to implement what you've requested and I'll run the source generator as well. 😁 Sounds good! I'm looking forward to getting these changes in!

0x5bfa commented 2 weeks ago

We should avoid updating models here.

Let's hold off:

A couple of things to get this all wrapped up...

Thank you for the review. If this is hard to review, we probably can separate the changes into a few PRs, merge into another branch on this repo and then merge that branch into the main.

@nickfloyd Here's the change list:

Lamparter commented 2 weeks ago

@0x5bfa Where do you want to bring these changes?

0x5bfa commented 2 weeks ago

To the upcoming PR.

0x5bfa commented 2 weeks ago

I fixed the CI. Probably it also should the following but I'd hold off for now

Lamparter commented 2 weeks ago

https://github.com/octokit/octokit.graphql.net/actions/runs/10925402467/job/30326798453?pr=325#step:9:15 There are lots of NuGet warnings here, should fix (in another PR)

nickfloyd commented 1 week ago

Hey @Lamparter & @0x5bfa thanks for the changes here ❤️. Everything looks good. Once you get the merge conflict resolved I'll get this merged in. Also, re: https://github.com/octokit/octokit.graphql.net/pull/321 - once you move that one out of draft I'll take a look at it.

Again, thank you both for making this and our community better!

0x5bfa commented 1 week ago

Some CI is failing, let's fix shortly.

Lamparter commented 1 week ago

Oh crap I forgot to update the codebase structure in the README