octokit / octokit.js

The all-batteries-included GitHub SDK for Browsers, Node.js, and Deno.
MIT License
6.93k stars 1.01k forks source link

[BUG]: Introduction of breaking changes in a patch release #2477

Closed wolfy1339 closed 1 year ago

wolfy1339 commented 1 year ago

What happened?

Automated renovate PRs were merged that contained breaking changes, since those versions dropped support for Node v14, v16

Now users won't be able to install these packages anymore

Versions

Octokit.js 2.0.21

Relevant log output

No response

Code of Conduct

gavacq commented 1 year ago

This is affecting our project as well and preventing new builds.

wolfy1339 commented 1 year ago

PRs hat need to be reverted #2474 and #2475

estraph commented 1 year ago

Confirming that this broke the release of one of our projects, because node 14 isn't supported anymore

 error @octokit/request-error@4.0.2: The engine "node" is incompatible with this module. Expected version ">= 18". Got "14.18.3"
github-actions[bot] commented 1 year ago

:tada: This issue has been resolved in version 2.0.22 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

estraph commented 1 year ago

Thanks for sorting this out @wolfy1339 @kfcampbell - error no longer happening for me.

github-actions[bot] commented 1 year ago

:tada: This issue has been resolved in version 3.0.0-beta.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket: