octokit / octokit.js

The all-batteries-included GitHub SDK for Browsers, Node.js, and Deno.
MIT License
6.93k stars 1.01k forks source link

[DOCS]: Code examples, statement ending with a colon #2515

Closed michaelsatish closed 1 year ago

michaelsatish commented 1 year ago

Describe the need

The README document has the below code statement ending with a colon. It should be a semicolon. There are three occurrence in the whole document.

import { createServer } from "node:http":

SDK Version

No response

API Version

No response

Relevant log output

No response

Code of Conduct

github-actions[bot] commented 1 year ago

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

wolfy1339 commented 1 year ago

Thank you for spotting those errors. Would you like to submit a fix for them?

michaelsatish commented 1 year ago

@wolfy1339 You're welcome. I will submit a PR.

github-actions[bot] commented 11 months ago

:tada: This issue has been resolved in version 3.1.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: