search

octokit / octokit.js

The all-batteries-included GitHub SDK for Browsers, Node.js, and Deno.
MIT License
6.97k stars 1.02k forks source link

How to implement OAuth with Deno Fresh #2535

Open austenstone opened 1 year ago

austenstone commented 1 year ago

I'm curious how we would properly implement OAuth web flow with the Deno Fresh framework?

It seems the web flow is heavily dependent on the middlewear. Could we somehow utilize this with Fresh middlewear??

I see Octokit has a way to get the token manually but I'm struggling to import @octokit/oauth-app in Deno world.

Here's my go at it: https://github.com/austenstone/fresh-github-oauth/tree/new

github-actions[bot] commented 1 year ago

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

wolfy1339 commented 1 year ago

What kind of errors are you getting while importing @octokit/oauth-app?

We may be able to fix some of them.

One important pointer for using Octokit in deno, don't import the package directly from NPM, use esm.sh

wolfy1339 commented 7 months ago

@austenstone Is this still an issue?