build(deps): replace `@gr2m/fetch-mock` with `fetch-mock`

octokit / octokit.js

The all-batteries-included GitHub SDK for Browsers, Node.js, and Deno.

MIT License

6.83k stars 1k forks source link

build(deps): replace `@gr2m/fetch-mock` with `fetch-mock` #2697

Closed wolfy1339 closed 2 weeks ago

wolfy1339 commented 2 weeks ago

Resolves #2696

Before the change?

Used a custom fork of fetch-mock for Fetch API support

After the change?

Use the fetch-mock module again, it has been updated to support the Fetch API

Pull request checklist

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

[ ] Yes
[ ] No

github-actions[bot] commented 2 weeks ago

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

gr2m commented 2 weeks ago

Oh I think there is a special module for using fetch mock with jest. Sorry I'm on my phone today

wolfy1339 commented 2 weeks ago

It seems there is a packaging issue with fetch-mock, files that are referenced in package.json as entrypoints are not present