search

octokit / octokit.net

A GitHub API client library for .NET
https://octokitnet.readthedocs.io/en/latest/
MIT License
2.67k stars 1.07k forks source link

[FEAT]: Expand Environments client for secrets and variables #2752

Open timheuer opened 1 year ago

timheuer commented 1 year ago

Describe the need

On the Environments client it should expose the ability for retrieving the Secrets and Variables for each Environment

SDK Version

Octokit.net 7.0.1

API Version

No response

Relevant log output

No response

Code of Conduct

drewid commented 8 months ago

Definitely have an interest in this, as the repository secrets just aren't granular enough. Plan on using those in conjunction with Azure Key Vault to have smooth GitHub to Azure deployment environment/branch/slot-related secrets.

drewid commented 8 months ago

@timheuer @kfcampbell @nickfloyd - I looked at it and have done the core work on this along with tests. Have been able to sucessfully have get all, get specific, upsert, and delete environment secrets to all work.

My understanding per the guidelines is the method for contributing to the repository is to create a personal fork, then when work is finished create and push to a repo branch, and then create a pull request. I am not seeing the ability to create a branch - I assume my status need to be modified for contributing to the project? I also cannot assign myself the task so assume that is related.

drewid commented 8 months ago

@timheuer @kfcampbell @nickfloyd checking back in on how you want me to proceed. Have implemented, tested and now have working live code changes done for both environment secrets and environment variables.

nickfloyd commented 8 months ago

@timheuer @kfcampbell @nickfloyd checking back in on how you want me to proceed. Have implemented, tested and now have working live code changes done for both environment secrets and environment variables.

Hey @timheuer Apologies for the delay on getting back to you and thanks for the follow up. Here are our contributing guidelines and some conventions that we use.

The basics are - create a fork, make your changes, write some tests, then create a PR. Because we serve more than 2000 external contributors across 75 different repos we have a process that we follow to help us prioritize things as well, have a look if you get the chance.

Most importantly, thank you for becoming part of the Octokit community! We cannot build the tools and help the millions of developers that we do without folks like you! So thank you ❤

Side note, I am going to review our contribution docs and see if I cannot simplify things there - please let me know if you have any feedback on those docs so that we can make them better for everyone!

drewid commented 8 months ago

Thanks @nickfloyd. On the contribution docs, main thing is that it references creating a branch, which either is outdated or contributor needs specific access.

Per the conventions doc I will create a PR with the following for review:

feat: Adds Environment Secrets & Variables