bugfix #2870

[b3b00]

Resolves #2870

---

Before the change?

When trying to delete a file an exception is raised stating System.ArgumentException: The value cannot be null or empty. (Parameter 'mediaType'). And the file is not deleted

After the change?

No exception is raised and the file is deleted.

Pull request checklist

• [ ] Tests for the changes have been added (for bug fixes / features)
• [ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

---

[kfcampbell]

Hmm...I'm uncomfortable making this change with such a broad impact. Can it be scoped down to the one request necessary?

[b3b00]

@kfcampbell , I agree that this can be dangerous. I will look at a way to narrow this fix to the delete request and make it available to other kind of request if the issue appears on other. Thanks for your comment

[nickfloyd]

@b3b00 if you get the chance post what your use (code) of the SDK here looks like - specifically I am trying to find out which resource client you're using so that we can help you craft a solution. We have some mechanisms in place to support adding headers to the request - adding where you have will definitely have some side effects for all of the other implementations that use SendData.

[b3b00]

Hello @nickfloyd, my code :

     public override async Task DeleteNote(string noteName)
        {
            if (gitHubClient != null)
            {
                var content = await NoteExists(noteName);
                if (content.exists)
                {
                    // this is were the exception happens
                    var deleteRequest =
                        new DeleteFileRequest($"DendrOnline : delete note {noteName}", content.content.Sha);
                    await gitHubClient.Repository.Content.DeleteFile(RepositoryId,$"notes/{noteName}.md" , deleteRequest);
                }
            }
        }