[BUG/FEAT]: BranchProtetionPushRestictions Properties Should Be Nullable

octokit / octokit.net

A GitHub API client library for .NET

https://octokitnet.readthedocs.io/en/latest/

MIT License

2.62k stars 1.07k forks source link

[BUG/FEAT]: BranchProtetionPushRestictions Properties Should Be Nullable #2900

Open wesdevpro opened 1 month ago

wesdevpro commented 1 month ago

What happened?

According to the official docs these fields can be null (this wont set the property in the UI on GitHub) However, Octokit.net does not allow for these properties to at least default to null but an empty list (this sets the property in the UI on GitHub).

Should/Can this be changed to allow developers to use the API to it's fullest extent?

Versions

Octokit.net

Relevant log output

No response

Code of Conduct

[X] I agree to follow this project's Code of Conduct

wesdevpro commented 2 weeks ago

@nickfloyd @kfcampbell I attempted to implement this feature but I get build issues that seem to be related to #2865. Is this possible? Also if so then I believe #2850 would also be affected from the same issue?