a better caching experience for Octokit

[shiftkey]

After discussions in #369 about WinInet I'm leaning towards a different approach for a couple of reasons:

• it's unclear if the WinInet issues will be fixed, let alone when
• what about platforms where WinInet isn't available?
• HttpClient has support for doing this "Russian Doll"-style of behaviour using DelegatingHandler

Tavis.PrivateCache has been proposed as a implementation of this, so I'm leaning towards one of two options around this:

Make Tavis.PrivateCache an development dependency, and bake it in

Pros:

• easier for users to get benefits of it
• less fiddling around with ctors

Cons:

• harder to debug (perhaps make this opt-out for those who are feeling brave)

  Expose DelegatingHandler in GitHubClient and let others do the work wiring it up

Pros:

• more future-proof
• others might want to do their own stuff with HttpClient

Cons:

• harder to get benefits for new users
• probably some more IoC pain

The work required is probably about the same, but I'm leaning toward option 1 because it'll be simpler for users of the library.

cc @paulcbetts @darrelmiller @niik

[haacked]

:thumbsup: to option 1

[darrelmiller]

I am happy to help in any way I can. My recent blog post on the Vary header (http://bizcoder.com/the-insanity-of-the-vary-header) was my first step to fixing the current vary implementation and the next major task is do a persistent storage mechanism. The current implementation is only an in-memory store.

[shiftkey]

The current implementation is only an in-memory store.

I think that's a "good enough" option for now for our use case, but perhaps down the track someone might want to implement their own backing store for it (imagine a service who wants to push that memory usage out of process, for example).

[nigel-sampson]

I created a naive implementation of the latter solution by creating a custom http client https://github.com/nigel-sampson/octokit.caching

[anaisbetts]

[shiftkey]

[anaisbetts]

Hubot img me Jonny Lee Miller 2015

[darrelmiller]

Oh, where oh where are the other 48 hours I need in a day.

[shiftkey]

Status update: I'm ranting and raving over in #781 about first class support for HttpClient/HttpMessageHandler - once I get that right I think this will be trivial to add - and I already have crazy ideas in my head about how to do it...

[darrelmiller]

Yesterday I did a major update to my HTTPCache to fix the problems with the way the vary header is handled. I also renamed it because how it can handle being a shared cache too! This also caused a change to the storage interface. Next step is to produce a persistent storage mechanism.

[shiftkey]

@darrelmiller so if I head down the road towards something like this does that make your life easier or harder?

[darrelmiller]

@shiftkey Much easier. Adding my cache would look pretty much exactly like you showed it in the example.

[github-actions[bot]]

👋 Hey Friends, this issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!