search

octokit / octokit.objc

GitHub API client for Objective-C
MIT License
1.84k stars 319 forks source link

Octclient events #279

Closed leichunfeng closed 9 years ago

leichunfeng commented 9 years ago
  1. Add commits、additions、deletions property to OCTPullRequest.
  2. Add commits property to OCTPushEvent.
  3. Add two fetches events methods to OCTClient+Events.
joshaber commented 9 years ago

Awesome :metal:

Just one comment, though the feedback in https://github.com/octokit/octokit.objc/pull/270#issuecomment-138575684 mostly applies too.

leichunfeng commented 9 years ago

@joshaber Please review it again.

joshaber commented 9 years ago

This looks great, just needs a merge it from master now that #270 has landed.

leichunfeng commented 9 years ago

OK

leichunfeng commented 9 years ago

@joshaber I have done it.

joshaber commented 9 years ago

Awesome, thank you!

leichunfeng commented 9 years ago

No thanks, it's my pleasure.